Min build requirements update #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Is the issue with FetchContent related to the changes in https://cmake.org/cmake/help/latest/release/3.30.html#deprecated-and-removed-features about FetchContent_Populate being deprecated? |
|
Yeah, the changes to fetch_content made it really awkward to do what we were doing. I came across several others with similar problems. It seems it was changed to make it work more like targets and single dependencies, but we were using to get a bunch of targets and configure the build, so the intention of CMake changes, and our use case then fits better with the submodule model. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…requirements_update
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
nightlark
requested changes
Oct 9, 2024
phlptp
commented
Oct 9, 2024
Co-authored-by: Ryan Mast <[email protected]>
nightlark
reviewed
Oct 9, 2024
nightlark
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will update to cmake 3.30 and make google test, zeromq, and google benchmarks as submodules.
Proposed changes